[PATCH] D156529: [AMDGPU][True16] Pre-commit addition tests.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 06:08:34 PDT 2023


kosarev added a comment.

> I mean like for wave32, we have test/CodeGen/AMDGPU/wave32.ll. It's not completely comprehensive, but it kept testing isolated when wave32 support was first added. At this point a lot of what's in it is probably redundant and duplicated in other tests

As Joe mentioned, we already have lots of t16 tests here, currently covering the support for fake instructions, but identical to what we would want for real ones, so feels like no need for special bring-up tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156529/new/

https://reviews.llvm.org/D156529



More information about the llvm-commits mailing list