[PATCH] D156103: [AMDGPU][NFC] Add True16 operand definitions.

Mon Aug 14 05:50:28 PDT 2023

kosarev added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:406
 def VOP_MADMK_F16 : VOP_MADMK <f16>;
 def VOP_MADMK_F16_t16 : VOP_MADMK <f16> {
   let IsTrue16 = 1;
----------------
Joe_Nash wrote:
> kosarev wrote:
> > Joe_Nash wrote:
> > > Shall this be renamed to include fake16? I guess a distinct true16 version will be added at a later point.
> > Should be split into real and fake definitions later when there's immediate need for that.
> But this *Is* the fake version, and when merged with the true16 version downstream both will exist. So I think it makes sense to rename immediately.
> when merged with the true16 version downstream both will exist.

Here upstream it will continue to be a fake instruction, which it is here, and downstream it will continue to be the real instruction, which it is there -- all until we decide to support both the versions.

There are hundreds of references to _t16 entities here in the mainline, none of which are real True16 things. Renaming them all right away would go against the whole idea of bringing in changes gradually.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156103/new/

https://reviews.llvm.org/D156103