[PATCH] D157089: [AMDGPU] Fix dealing with register interval endpoints in SIInsertWaitcnts.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 05:38:15 PDT 2023


foad added a comment.

Yes it looks fine but I would not call it a "fix" since there is no bug here. (The rationale you gave before: "The original code is known to be incorrect because it violates use conventions for RegInterval as a concept, which in turn we know from its other uses, of which there are many" no longer applies, since this is no longer based on D157088 <https://reviews.llvm.org/D157088>.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157089/new/

https://reviews.llvm.org/D157089



More information about the llvm-commits mailing list