[PATCH] D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation

Eymen Ünay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 02:34:52 PDT 2023


Eymay added a comment.

In D157533#4574209 <https://reviews.llvm.org/D157533#4574209>, @sgraenitz wrote:

> Looks great, thanks! I think at some point we should add a `.thumb` section with `.thumb_func` functions to our tests, so we get coverage for the code that handles ARM-Thumb transitions. However, I guess we need ARM stubs for it first?

Great idea, I agree an arm_thumb_interworking test is necessary. Without stubs for Arm, we should be able to test `bl thumb_func` as long as it is in range. 
Another thing we need, for this test to work, is a TargetFlag dependent triple like @lhames mentioned on discourse <https://discourse.llvm.org/t/runtimedyldchecker-jitlink-check-thumb-support/72581/8>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157533/new/

https://reviews.llvm.org/D157533



More information about the llvm-commits mailing list