[PATCH] D155484: [AArch64] Global Isel Funnel Shift Lowering

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Can you add the llvm/test/CodeGen/AArch64/funnel-shift.ll test changes back to this patch too? Otherwise this looks good to me.



================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:1031
+  
+  // Deal with this case in the optimizer (Combine.td)
+  if (!VRegAndVal || VRegAndVal->Value.urem(BitWidth) == 0)
----------------
Maybe:
```
// Lower non-constant shifts and leave zero shifts to the optimizer.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155484/new/

https://reviews.llvm.org/D155484