[PATCH] D157086: [LiveRange] Fix inaccurate verification of live-in PhysRegs

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 00:44:07 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Seems reasonable.  I wonder if you could get an IR test with `llc -early-live-intervals`.



================
Comment at: llvm/lib/CodeGen/LiveRangeCalc.cpp:223
+      bool IsLiveIn = MBB->isLiveIn(PhysReg);
+      for (MCRegAliasIterator Alias(PhysReg, TRI, false); !IsLiveIn && Alias.isValid(); ++Alias)
+        IsLiveIn = MBB->isLiveIn(*Alias);
----------------
This looks like a job for `/*IncludeSelf=*/true`, but I guess it wouldn't actually shorten the code much the way you've written it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157086/new/

https://reviews.llvm.org/D157086



More information about the llvm-commits mailing list