[PATCH] D157210: [symbolizer] Change reaction on invalid input
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 13 23:53:54 PDT 2023
jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.
As far as I can tell, the only "fix" you've made since the version that caused the hangs was to the test itself. That means that llvm-symbolizer could still hang under certain conditions surely, when it didn't used to...
If I squint hard enough, I could maybe see why this change is acceptable, but I'd like you to explain the change and why it isn't going to cause end-users hanging issues in practice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157210/new/
https://reviews.llvm.org/D157210
More information about the llvm-commits
mailing list