[PATCH] D157230: [SPARC][IAS] Add SETX pseudoinstruction

[Koakuma via Phabricator via llvm-commits]

koakuma added inline comments.


================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:672
+  if (IsImm && IsSmallNegative) {
+    Instructions.push_back(MCInstBuilder(SP::ORri)
+                               .addReg(MCRegOp.getReg())
----------------
barannikov88 wrote:
> Can this be delegated to expandSET, too? It appears to have some logic related to handling of small negative numbers.
> 
Unfortunately no, on 64-bit mode `set` is defined to zero the upper 32-bits of the destination register.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157230/new/

https://reviews.llvm.org/D157230