[PATCH] D156889: [mlir][cf] Add ControlFlow to SCF lifting pass

[Markus Böck via Phabricator via llvm-commits]

zero9178 added a comment.

In D156889#4582676 <https://reviews.llvm.org/D156889#4582676>, @Hardcode84 wrote:

> I run this pass on our python testsuite and results looking good
>
>   46 failed, 10950 passed, 3466 skipped, 445 xfailed, 46 warnings in 252.77s (0:04:12)
>
> Look like most of the failures come from `scf.execute_region`, but I didn't looked in detail yet.
> Example of failing IR https://gist.github.com/Hardcode84/8e55de4009e190af59cd2e7c25ebdbfa

Thank you so much for testing! Did you use the `transformCFGToSCF` method or the `lift-cfg-to-scf` pass? Neither of the two currently traverse into subregions of ops. Unless you run the former on the region of the `scf.execute` it likely didn't do any transformations.
I think `transformCFGToSCF` should only operate on one region at a time, but we could think about making the `lift-cfg-to-scf` pass traverse into subregions in post-order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156889/new/

https://reviews.llvm.org/D156889