[PATCH] D157210: [symbolizer] Change reaction on invalid input

[Douglas Yung via Phabricator via llvm-commits]

dyung added a comment.

Hi @sepavloff, I'm seeing some weird behavior on our Windows build bot after your change (https://lab.llvm.org/buildbot/#/builders/216/builds/25497).

When building your change, it seems one of the tests is hanging, and it keeps a lock on llvm-symbolizer.exe which then causes subsequent builds to fail as they cannot write to the file. The only way to recover the build bot that I've found is to login, kill the zombie llvm-symbolizer process and then I can delete the binary so that it can be re-written on a later build. Any idea why this might be happening?

>From process explorer, this is the command that is getting stuck:

  "c:\program files\python310\python.exe" Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\test\Support\interrupts.test symbolizer z:\b\llvm-clang-x86_64-sie-win\build\bin\llvm-symbolizer.exe

I'm also seeing a similar issue affecting another Windows build bot https://lab.llvm.org/buildbot/#/builders/65/builds/10919. Something about your change does not seem to sit well with Windows builders. Can you take a look or revert if you need time to investigate? I may revert it soon since it requires manual intervention to get the build bot back running again, but wanted to check and see if you had any idea what might be happening first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157210/new/

https://reviews.llvm.org/D157210