[PATCH] D121187: [DAGCombiner][VP] Add DAGCombine for VP_MUL.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 12 10:54:40 PDT 2023
craig.topper added a comment.
I'm concerned about the number of checks for IsVP. It looks like maybe this function will be hard to maintain in the future. Every new change will have to think about whether it works for VP. Most LLVM developers don't care about VP so may miss this detail.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121187/new/
https://reviews.llvm.org/D121187
More information about the llvm-commits
mailing list