[PATCH] D157717: [X86][Codegen] Remove dead code for ADCX/ADOX

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:1377
 
-let Predicates = [HasADX], Defs = [EFLAGS], Uses = [EFLAGS],
-    Constraints = "$src1 = $dst", hasSideEffects = 0 in {
+let Defs = [EFLAGS], Uses = [EFLAGS], Constraints = "$src1 = $dst", hasSideEffects = 0 in {
   let SchedRW = [WriteADC], isCommutable = 1 in {
----------------
craig.topper wrote:
> Why delete the predcate?
Except assembler predicate like `In64BitMode`, a predicate only has effect when the pattern is not empty.
There is no pattern for ADCX/ADOX, so I remove the pattern. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157717/new/

https://reviews.llvm.org/D157717