[PATCH] D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0)

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

Partial re-review comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1539-1541
+    // The faster non-TOC based local-exec sequence is represented by the
+    // hasAIXSmallLocalExecTLS() subtarget feature and the MO_TPREL_FLAG
+    // target flag.
----------------
The actually important thing is the target flag and the instruction opcode.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1543-1544
+    const MachineOperand &MO = MI->getOperand(2);
+    if (Subtarget->hasAIXSmallLocalExecTLS() &&
+        (MO.getTargetFlags() & PPCII::MO_TPREL_FLAG)) {
+      LowerPPCMachineInstrToMCInst(MI, TmpInst, *this);
----------------
Restrict the check to just the target flag (moving the other "condition" to be just an assertion).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155600/new/

https://reviews.llvm.org/D155600