[PATCH] D157733: [DAG] NFC: Add getScalarizeExtOrTrunc

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:952
+  /// IsSigned) or truncating it.
+  SDValue getExtOrTrunc(bool IsAny, bool IsSigned, SDValue Op, const SDLoc &DL,
+                        EVT VT) {
----------------
Instead of isAny / isSigned, I'de expect it to take the extend opcode


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:969
+  /// corresponding scalar type then either any-extending or truncating it.
+  SDValue getScalarizedAnyExtOrTrunc(SDValue Op, const SDLoc &DL, EVT VT);
+
----------------
I'm not sure scalarized is the right name, you aren't unrolling a vector operation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157733/new/

https://reviews.llvm.org/D157733