[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:13813
+11: Use pass-by-reference (byref) instead of pass-by-value (byval) for struct
+    arguments in function ABI. Callee is responsible to allocate memory and
+    make a copy of the struct. Note that the backend still supports byval for
----------------
cfang wrote:
> arsenm wrote:
> > cfang wrote:
> > > arsenm wrote:
> > > > Specify C ABI
> > > Do not get what to do to "Specify C ABI"? Can you suggest explicitly? Thanks.
> > Add the letter C
> ... in function C ABI?  Or should we remove "function"? 
Can just say C, doesn't really matter if you state function or not. function is implied


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155986/new/

https://reviews.llvm.org/D155986