[PATCH] D157746: [BOLT][DWARF][NFC] Fix handling of invalid DIE references

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 11:54:47 PDT 2023


ayermolo created this revision.
Herald added subscribers: treapster, hoy, modimo, wenlei.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
ayermolo requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, jplehr, yota9, sstefan1.
Herald added a project: LLVM.

Compiler can generate DIE References that are invalid. Previously BOLT could
assert when writing out IR to .debug_info. Changed where DIE offsets are changed
so that it's always done. Thus making sure that assert is not triggered.

Added more specific warnings, and ability to print out invalid referenced DIE
offset when verbosity >=1.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157746

Files:
  bolt/include/bolt/Core/DIEBuilder.h
  bolt/lib/Core/DIEBuilder.cpp
  bolt/test/X86/dwarf4-invalid-reference-die-offset-no-internal-dwarf-error.s
  bolt/test/X86/dwarf4-invalid-reference-die-offset-with-internal-dwarf-error-cant-parse-die.s
  bolt/test/X86/dwarf4-invalid-reference-die-offset-with-internal-dwarf-error-invalid-die.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157746.549477.patch
Type: text/x-patch
Size: 63255 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230811/61b6f71a/attachment.bin>


More information about the llvm-commits mailing list