[PATCH] D142879: [RISCV] Emit relocation for uleb128

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 11:09:40 PDT 2023


MaskRay added a comment.

In D142879#4576026 <https://reviews.llvm.org/D142879#4576026>, @kito-cheng wrote:

> @MaskRay Really appropriate your help! it seems like I didn't handle the dwarf stuffs right according your version, and ULEB128 relocation support might be a compatible issue between GNU and LLVM toolchain, so I wondering do you think it's better to split this patch into add relocation number only and add the lld support(D142880 <https://reviews.llvm.org/D142880>) first for LLVM 17 branch?

Thanks:) Having the `ELF_RELOC(R_RISCV_SET_ULEB128,       60) ... 61` change in release/17.x will be useful.

Having the lld change will be good for our compatibility story if we can catch the release schedule. But it seems that the change is quite complex and I am unsure we have sufficient time...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142879/new/

https://reviews.llvm.org/D142879



More information about the llvm-commits mailing list