[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

[John McIver via Phabricator via llvm-commits]

jmciver added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:809-811
+  Updater.AddAvailableValue(
+      Alloca.getParent(),
+      getInitialValueOfAllocation(&Alloca, nullptr, VectorTy));
----------------
arsenm wrote:
> This is very specifically handling alloca, not any random allocation like function
@arsenm thanks for the feedback. I added functionality to `getInitalValueOfAllocation` to handle `alloca` instructions specifically. This is being done as preliminary to some possible refactorizations allowing uninitialized memory to move to poison semantics. The behavior for these changes would be the same for `alloca` and allocation like functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155773/new/

https://reviews.llvm.org/D155773