[PATCH] D157633: [MachineScheduler] Account for lane masks in basic block liveins

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 10:35:17 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/ScheduleDAGInstrs.cpp:228-229
+          auto [Unit, Mask] = *U;
+          if (Mask.none())
+            Mask = LaneBitmask::getAll();
+          if ((Mask & LI.LaneMask).any() && !Uses.contains(Unit))
----------------
foad wrote:
> This seems to be some weird special case in the generated LaneMaskLists for registers with a single regunit. Or something.
the none is just broken, it should emit all


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157633/new/

https://reviews.llvm.org/D157633



More information about the llvm-commits mailing list