[PATCH] D157690: [GlobalISel] Rewrite some simple rules using MIR Patterns
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 11 10:00:07 PDT 2023
arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-trivial-arith.mir:313-315
+ ; CHECK-NEXT: %c:_(s64) = G_CONSTANT i64 72340172838076673
+ ; CHECK-NEXT: %mul:_(s64) = G_MUL %zext_zero, %c
+ ; CHECK-NEXT: $x0 = COPY %mul(s64)
----------------
arsenm wrote:
> This regressed?
I think I see why, this is the lack of constant folding extensions which I have a patch for. I think we need less look through handling and more consistent constant and copy folding
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157690/new/
https://reviews.llvm.org/D157690
More information about the llvm-commits
mailing list