[PATCH] D153337: [MachineLICM][WinEH] Don't hoist register reloads out of funclets

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

This looks correct to me.



================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:540-543
     for (const auto &LI : BB->liveins()) {
       for (MCRegAliasIterator AI(LI.PhysReg, TRI, true); AI.isValid(); ++AI)
         PhysRegDefs.set(*AI);
     }
----------------
arsenm wrote:
> We're moving towards reverse block liveness. Modern liveness queries start at the end of the block and walk backwards, but this is walking forward looking for defs. Can this pass switch to using LiveRegUnits and stepBackwards?
That sounds like a good idea, but it seems out of scope for this bug fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153337/new/

https://reviews.llvm.org/D153337