[PATCH] D157567: PreISelIntrinsicLowering: Check RuntimeLibcalls instead of TLI for memory functions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/PreISelIntrinsicLowering.cpp:208
 bool PreISelIntrinsicLowering::expandMemIntrinsicUses(Function &F) const {
+  const TargetLowering *TLI = TM.getSubtargetImpl(F)->getTargetLowering();
   Intrinsic::ID ID = F.getIntrinsicID();
----------------
nikic wrote:
> This is using the TLI for the wrong function: It's the one for the intrinsic, rather than the one for the intrinsic caller.
I think this is harmless because the runtime libcall system isn't really refined per function. It's effectively a hardcoded table driven off the triple


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157567/new/

https://reviews.llvm.org/D157567