[PATCH] D157133: [AMDGPU] Extend CalculateByteProvider to capture vectors and signed

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:10922-10924
+          return Op.getValueType().isVector()
+                     ? DAG.getBitcast(MVT::getIntegerVT(32), Op)
+                     : Op;
----------------
this could probably be just return the getBitcast


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:10932-10934
+        if (Op.getValueType().isVector()) {
+          Op = DAG.getBitcast(MVT::getIntegerVT(Op.getValueSizeInBits()), Op);
+        }
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157133/new/

https://reviews.llvm.org/D157133