[PATCH] D156158: [LAA] Rename and fix semantics of MaxSafeDepDistBytes to MinDepDistBytes

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for the update! It looks like there's some clang-format issue (as reported by the pre-commit checks), but overall looks good pending clarification about the test for the change in behavior



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2010
+  // since there is a backwards dependency.
+  uint64_t MaxVF = MinDepDistBytes / (TypeByteSize * Stride);
   LLVM_DEBUG(dbgs() << "LAA: Positive distance " << Val.getSExtValue()
----------------
fhahn wrote:
> This is the only non-NFC part of the patch, IIUC? Would it be possible to create a test case showing the new behavior?
Would it be possible to add a test for the functional change here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156158/new/

https://reviews.llvm.org/D156158