[PATCH] D157504: AMDGPU: Check for implicit defs before constant folding instruction

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 06:57:38 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.

> Many GlobalISel tests show regressions for two reasons. First, it's
> not setting dead flags in some cases. The reason we care about the
> dead flags is compensating for failure to constant fold common
> operations in the first place.

Remove this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157504/new/

https://reviews.llvm.org/D157504



More information about the llvm-commits mailing list