[PATCH] D155633: [OpenMP][OpenMPIRBuilder] Add kernel launch codegen to emitTargetCall
Akash Banerjee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 11 06:35:44 PDT 2023
TIFitis added inline comments.
================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:5066-5073
+ if (!arg->getType()->isPointerTy()) {
+ combinedInfo.BasePointers.clear();
+ combinedInfo.Pointers.clear();
+ combinedInfo.Sizes.clear();
+ combinedInfo.Types.clear();
+ combinedInfo.Names.clear();
+ return;
----------------
Given the args are added by this tests themselves, I think this condition is not needed.
================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:5084
+ combinedInfo.Sizes.emplace_back(ompBuilder.Builder.getInt64(
+ ompBuilder.M.getDataLayout().getTypeAllocSize(arg->getType())));
+ }
----------------
TIFitis wrote:
> Can you please check if this works with function arguments?
>
> AFAIK getTypeAllocSize doesn't work on function arguments, in that case we might want to move this function as a callback to MLIR.
Sorry, forgot this function is inside test. Please ignore above comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155633/new/
https://reviews.llvm.org/D155633
More information about the llvm-commits
mailing list