[PATCH] D157511: GlobalISel: Add constant fold combine for zext/sext/anyext

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 06:27:50 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:641-644
+  bool matchConstantFoldCastOp(MachineInstr &MI, APInt &MatchInfo);
+
+  /// Do constant folding when opportunities are exposed after MIR building.
+  bool matchConstantFoldBinOp(MachineInstr &MI, APInt &MatchInfo);
----------------
Pierre-vh wrote:
> nit: could remove the second comment and just put the decls right next to each other.
I think doxygen only handles that when they have the same name, these are different 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157511/new/

https://reviews.llvm.org/D157511



More information about the llvm-commits mailing list