[PATCH] D157688: [LowerTypeTests,ARM] Support Armv8-M BTI in jump tables.
Oliver Stannard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 11 04:31:16 PDT 2023
olista01 added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:1486
+ // setting to ensure BTI can be assembled.
+ F->addFnAttr("target-features", "+pacbti");
+ } else if (CanUseThumbBWJumpTable) {
----------------
Does calling `addFnAttr` twice concatenate the value strings, or will this replace the "+thumb-mode" attribute? This should also be added to the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157688/new/
https://reviews.llvm.org/D157688
More information about the llvm-commits
mailing list