[PATCH] D157690: [GlobalISel] Rewrite some simple rules using MIR Patterns
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 11 03:56:36 PDT 2023
foad added inline comments.
================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:364
- [{ return Helper.matchUndefSelectCmp(*${root}); }]),
- (apply [{ Helper.replaceSingleDefInstWithOperand(*${root}, 2); }])
>;
----------------
This `2` was a bug - in `G_SELECT $dst, $undef, $x, $y` it was picking `$x` but the comment says "y".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157690/new/
https://reviews.llvm.org/D157690
More information about the llvm-commits
mailing list