[PATCH] D156349: [DAG] Support store merging of vector constant stores

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 03:55:27 PDT 2023


bjope added a comment.

In D156349#4577235 <https://reviews.llvm.org/D156349#4577235>, @reames wrote:

> @bjope I relanded with the fix for your reported issue since it turned out to be fairly simple.  Can you confirm that everything works on your original example?
>
> Also, for future reference, feel free to just revert in a case like this.  You don't need to wait for me to see the comments.  Clear compiler crash or regression with a patch which reverts cleanly - go for it.  You're doing the author a favor.

@reames: Ok, great!, Thanks a lot, and I can confirm that the original test case now pass with the updated patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156349/new/

https://reviews.llvm.org/D156349



More information about the llvm-commits mailing list