[PATCH] D157690: [GlobalISel] Rewrite some simple rules using MIR Patterns

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 03:37:44 PDT 2023


foad added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-select.mir:12
     ; CHECK-LABEL: name: test_combine_select_same_res
-    ; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0
+    ; CHECK: liveins: $x0, $x1
+    ; CHECK-NEXT: {{  $}}
----------------
Pierre-vh wrote:
> foad wrote:
> > What has caused this difference?
> Below in `test_combine_select_undef_res0_res1` we have a copy `$x0` instead of `$x1`, not sure why
Oh I see, nothing has really changed in test_combine_select_same_res. Could you precommit a patch that just regenerates the checks for this file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157690/new/

https://reviews.llvm.org/D157690



More information about the llvm-commits mailing list