[PATCH] D157688: [LowerTypeTests,ARM] Support Armv8-M BTI in jump tables.

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 02:50:50 PDT 2023


olista01 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:1486
+      // that supports it, to ensure the jump table compiles successfully.
+      F->addFnAttr("target-cpu", "cortex-m85");
+    } else if (CanUseThumbBWJumpTable) {
----------------
It would be better to add `pacbti` to `target-features`, because setting the cpu might enable other features, such as MVE.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157688/new/

https://reviews.llvm.org/D157688



More information about the llvm-commits mailing list