[PATCH] D157621: [CHR] Fix up phi nodes with unreachable predecessors (PR64594)

[Nikita Popov via Phabricator via llvm-commits]

nikic updated this revision to Diff 549295.
nikic added a comment.
Herald added subscribers: kerbowa, jvesely.

Add -verify-region-info to test, adjust verifier to allow unreachable predecessor. This also resolves a FIXME in a StructurizeCFG test.

RegionInfo ignores blocks not connected to the dominator tree during analysis, so we should also ignore them during verification.

A possible alternative here would be that we shouldn't create regions with unreachable predecessors, though looking at the construction algorithm I'm not clear on how one would do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157621/new/

https://reviews.llvm.org/D157621

Files:
  llvm/include/llvm/Analysis/RegionInfoImpl.h
  llvm/lib/Transforms/Instrumentation/ControlHeightReduction.cpp
  llvm/test/Transforms/PGOProfile/chr-dead-pred.ll
  llvm/test/Transforms/StructurizeCFG/AMDGPU/backedge-id-bug-xfail.ll
  llvm/test/Transforms/StructurizeCFG/AMDGPU/backedge-id-bug.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157621.549295.patch
Type: text/x-patch
Size: 12702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230811/399623b1/attachment.bin>