[PATCH] D157658: [[llvm][AMDGPU][NFC]: Robustify mem intrinsic test

Nathan Sidwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 14:54:29 PDT 2023


urnathan created this revision.
urnathan added a reviewer: arsenm.
Herald added subscribers: kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
urnathan requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

This test captures branch labels and uses them in phi matchers (or vice versa), but it doesn't actually capture or check the label definitions themselves. The difference is that the latter doesn't have a leading '%', which the former has and is captured. Thus the test is a little brittle.  This redoes the label matching to also match the label definitions.  I.e. the '%' is no longer part of the capture, and must be provided at the use point too.

Discovered when a patch set I'm working on disturbed the label numbering here.

Matt, I think you authored this test?


https://reviews.llvm.org/D157658

Files:
  llvm/test/CodeGen/AMDGPU/lower-mem-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157658.549179.patch
Type: text/x-patch
Size: 118216 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230810/de205585/attachment-0001.bin>


More information about the llvm-commits mailing list