[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:13812-13813
     to the function.
+11: Use pass-by-reference (byref) instead of pass-by-value (byval) for struct
+    arguments in function ABI. Callee is responsible to allocate memory and
+    make a copy of the struct. Note that the backend still supports byval for
----------------
s/to allocate memory/for allocating stack memory/


================
Comment at: llvm/docs/AMDGPUUsage.rst:13813
+11: Use pass-by-reference (byref) instead of pass-by-value (byval) for struct
+    arguments in function ABI. Callee is responsible to allocate memory and
+    make a copy of the struct. Note that the backend still supports byval for
----------------
Specify C ABI


================
Comment at: llvm/docs/AMDGPUUsage.rst:13814
+    arguments in function ABI. Callee is responsible to allocate memory and
+    make a copy of the struct. Note that the backend still supports byval for
+    struct arguments.
----------------
copying the value of the struct if modified


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155986/new/

https://reviews.llvm.org/D155986