[PATCH] D157036: Emit a .debug_str_offsets section with dsymutil to support DW_FORM_strx in dsymutil.

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham updated this revision to Diff 549131.
rastogishubham marked 9 inline comments as done.
rastogishubham added a comment.
Herald added a reviewer: jdoerfert.
Herald added subscribers: jplehr, sstefan1.

Thanks for the review Alexey.

Added a test to specifically check for strx and str_offsets_base, similar to dwarf5-addr_base.test. One thing to note, right now, when using --update, the strx1's get converted to strxs, I don't know if we want to change that.

Moved AttrStrOffsetBaseSeen to AttributesInfo

Removed Dwarf5CUSeen

Added check for DW_TAG_compile_unit tag when adding a DW_AT_str_offsets_base in a CU

Removed patchStrOffsetsBase, added the code to cloneScalarAttribute

Moved Dwarf5 check to emitStringOffsets


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157036/new/

https://reviews.llvm.org/D157036

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/test/tools/dsymutil/ARM/dwarf5-addr_base.test
  llvm/test/tools/dsymutil/ARM/dwarf5-addrx-0x0-last.test
  llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test
  llvm/test/tools/dsymutil/ARM/dwarf5-macho.test
  llvm/test/tools/dsymutil/ARM/dwarf5-str_offsets_base-strx.test
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base-str_off_base/1.o
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base-str_off_base/2.o
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base-str_off_base/3.o
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base/1.o
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base/2.o
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base/3.o
  llvm/test/tools/dsymutil/X86/dwarf5-addrbase-broken.test
  llvm/test/tools/dsymutil/X86/dwarf5-addrx.test
  llvm/test/tools/dsymutil/X86/dwarf5-loclists.test
  llvm/test/tools/dsymutil/X86/op-convert-offset.test
  llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-addresses.test
  llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-rnglists.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157036.549131.patch
Type: text/x-patch
Size: 68634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230810/6509dbee/attachment.bin>