[PATCH] D156722: [CSSPGO] Support stale profile matching for LTO

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2123
+    for (auto &I : BB) {
+      // Process inlined code.
+      if (DILocation *DIL = I.getDebugLoc()) {
----------------
Might be good to mention IR flattening in the comment somewhere which is needed as the flattened profile is always used for matching.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2130
+          if (FunctionSamples::ProfileIsProbeBased &&
+              isa<PseudoProbeInst>(&I)) {
+            // For pseudo probe mode, extracting inline info from the probe inst
----------------
Do we also want to flatten for callsite probes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156722/new/

https://reviews.llvm.org/D156722