[PATCH] D157623: [lld][COFF] Remove incorrect flag from EHcont table

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Thanks!



================
Comment at: llvm/tools/llvm-readobj/COFFDumper.cpp:864
+                    4 + Stride, PrintGuardFlags);
     } else {
       printRVATable(Tables.GuardFidTableVA, Tables.GuardFidTableCount, 4);
----------------
You can simplify the code and eliminate all these `else` clauses by changing this condition above in printRVATable:
```
  if (PrintExtra)
      PrintExtra(OS, reinterpret_cast<const uint8_t *>(I));
>>
  if (EntrySize == 5)
      PrintExtra(OS, reinterpret_cast<const uint8_t *>(I));
```

It's not general to more than a byte of flags, but that's true already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157623/new/

https://reviews.llvm.org/D157623