[PATCH] D157416: [RISCV][GlobalISel] Legalize multiplication
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 10 09:40:02 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp:112
+
+ getActionDefinitionsBuilder({G_SMULH, G_UMULH}).legalFor({XLenLLT}).lower();
+ } else {
----------------
craig.topper wrote:
> Why do we need .lower() on this? We have instructions for G_SMULH and G_UMULH.
I would assume you want some clamping before going direct to lower (although I wouldn't be surprised if there wasn't complete support for mulh lowering)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157416/new/
https://reviews.llvm.org/D157416
More information about the llvm-commits
mailing list