[PATCH] D157607: [LegalizeTypes] Support promotion for vp bitmanip sdnodes.

[Luke Lau via Phabricator via llvm-commits]

luke accepted this revision.
luke added a comment.
This revision is now accepted and ready to land.

LGTM. As a side note, there's a lot of duplication between the VP and non-VP nodes here. I wonder if it's time to introduce some sort of helper/abstraction for it



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:536
+  SDValue Mask = N->getOperand(1);
+  SDValue VL = N->getOperand(2);
+  return DAG.getNode(ISD::VP_LSHR, dl, NVT,
----------------
Nit: Should we use EVL instead of VL since it's more VP specific?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157607/new/

https://reviews.llvm.org/D157607