[PATCH] D157495: [WIP] Run SimplifyCFG from Atomic-Expand on CAS loop blocks.
Pravin Jagtap via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 10 05:10:28 PDT 2023
pravinjagtap added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/global_atomics_scan_fadd.ll:2165-2184
-; GFX1164-NEXT: s_mov_b64 s[2:3], 0
; GFX1164-NEXT: s_delay_alu instid0(VALU_DEP_1)
-; GFX1164-NEXT: v_mul_f32_e32 v2, 4.0, v0
-; GFX1164-NEXT: s_waitcnt lgkmcnt(0)
-; GFX1164-NEXT: s_load_b32 s4, s[0:1], 0x0
+; GFX1164-NEXT: v_mul_f32_e32 v0, 4.0, v0
; GFX1164-NEXT: s_waitcnt lgkmcnt(0)
-; GFX1164-NEXT: v_mov_b32_e32 v1, s4
----------------
I am not sure whether this is what we are expecting. None of the existing test-cases need update for this change. I am struggling to demonstrate the actual benefits of running SimplifyCFG of CAS blocks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157495/new/
https://reviews.llvm.org/D157495
More information about the llvm-commits
mailing list