[PATCH] D157320: [AArch64][PAC] Remove duplication of LR sign/auth implementations

Anatoly Trosinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 03:09:27 PDT 2023


atrosinenko updated this revision to Diff 548946.
atrosinenko added subscribers: ikudrin, olista01.
atrosinenko added a comment.

Rebased onto current main branch (after D156428 <https://reviews.llvm.org/D156428>). Further simplified the code by introducing the `mergeOutliningCandidateAttributes()` callback.

This did change the way how epilogue of an outlined function is emitted (no negate_ra_sign_state after `AUTI(A|B)SP`) but I hope it is a minor change.
The reason for async unwind info not being requested for an outlined function is the `minsize` function attribute (and, interestingly, the `AArch64FunctionInfo::needsAsyncDwarfUnwindInfo()` function explicitly mentions the case of an "outlined function" in its comment).

cc @olista01, @ikudrin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157320/new/

https://reviews.llvm.org/D157320

Files:
  llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
  llvm/lib/Target/AArch64/AArch64FrameLowering.h
  llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
  llvm/lib/Target/AArch64/AArch64InstrInfo.h
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-sp-mod.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157320.548946.patch
Type: text/x-patch
Size: 14626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230810/51b40422/attachment.bin>


More information about the llvm-commits mailing list