[PATCH] D157475: [GlobalISel] introduce MIFlag::NoConvergent

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:151
+
+    bool IsConvergent = true;
   };
----------------
yassingh wrote:
> Missed doc comment here
Fix the doc 


================
Comment at: llvm/test/CodeGen/MIR/AMDGPU/noconvergent.mir:29
+    %2:sreg_32 = IMPLICIT_DEF
+    %3:sreg_32 = noconvergent S_ADD_I32 %2, 1, implicit-def $scc
+...
----------------
Arguably the verifier should reject this 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157475/new/

https://reviews.llvm.org/D157475