[PATCH] D157588: [RISCV] Add overlapping constraints label

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 01:18:36 PDT 2023


wangpc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2252
   defm _VV : VPseudoBinary<m.wvrclass, m.vrclass, m.vrclass, m,
-                           "@earlyclobber $rd">;
+                           "@earlyclobber $rd", /* sew = */ 0, TargetConstraintType>;
 }
----------------
If `sew=0` is the default value, then you can just use named argument `TargetConstraintType=TargetConstraintType` only here.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2301
+multiclass VPseudoBinaryW_WX<LMULInfo m, int TargetConstraintType = 1> {
+  defm "_WX" : VPseudoBinary<m.wvrclass, m.wvrclass, GPR, m, /*Constraint*/ "", /* sew */ 0, TargetConstraintType>;
 }
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157588/new/

https://reviews.llvm.org/D157588



More information about the llvm-commits mailing list