[PATCH] D157583: [RISCV] Stop performFP_TO_INTCombine from folding with ISD::FRINT.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 23:01:08 PDT 2023


craig.topper created this revision.
craig.topper added reviewers: fakepaper56, asb, reames.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added subscribers: wangpc, eopXD, MaskRay.
Herald added a project: LLVM.

FRINT was added to matchRoundingOp after this function was written.
So FRINT was not tested originally.

For vectors, folding this causes us to create a CSR swap that tries
to write 7 to FRM. This is an illegal value and will cause the CSR
write to fail.

While this might be a legal fold we could do, I'm disabling it for
now so we can backport to LLVM 17 with the least risk.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157583

Files:
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/test/CodeGen/RISCV/rvv/double-round-conv.ll
  llvm/test/CodeGen/RISCV/rvv/float-round-conv.ll
  llvm/test/CodeGen/RISCV/rvv/half-round-conv.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157583.548880.patch
Type: text/x-patch
Size: 56483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230810/5c170a43/attachment.bin>


More information about the llvm-commits mailing list