[PATCH] D155790: PreISelIntrinsicLowering: don't expand memcpys in minsize functions, even with no-builtins.

Wed Aug 9 21:05:43 PDT 2023

aemerson added a comment.

In D155790#4575156 <https://reviews.llvm.org/D155790#4575156>, @arsenm wrote:

> In D155790#4551945 <https://reviews.llvm.org/D155790#4551945>, @aemerson wrote:
>
>> In D155790#4551886 <https://reviews.llvm.org/D155790#4551886>, @arsenm wrote:
>>
>>> In D155790#4551830 <https://reviews.llvm.org/D155790#4551830>, @aemerson wrote:
>>>
>>>>> I think the fix that avoids the current problem, and solves my desires is to move from checking TargetLibraryInfo.hasLibFunc(memcpy) to checking if TargetLoweringInfo::getLibcallName(memcpy) is valid (plus maybe some additional libcall-is-valid-for-addrspace checks?). Sorting out the general libcall mess for freestanding is a problem for another day
>>>>
>>>> Are you working on this? If not we'd like to get this fixed and have the previous behavior restored.
>>>>
>>>>> 
>>>
>>> No, I thought you were since you posted the patch
>>
>> Ok got it.
>
> I interpreted this as you were doing it but I did this in D157567 <https://reviews.llvm.org/D157567>

Yeah I was going, I'm just on vacation so hadn't gotten around to it. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155790/new/

https://reviews.llvm.org/D155790