[PATCH] D157563: [CodeGen] Move function splitting tests from X86 to Generic (NFC)
Daniel Hoekwater via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 17:26:08 PDT 2023
dhoekwater marked 2 inline comments as done.
dhoekwater added inline comments.
================
Comment at: llvm/test/CodeGen/Generic/machine-function-splitter.ll:9
+; COM: Machine function splitting with AFDO profiles on X86
+; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-X86-MFS
+; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-X86-MFS2
----------------
snehasish wrote:
> s/X86-MFS/MFS-X86/ to be consistent with the convention you've set in the prior RUN lines?
Good point, I just changed the convention to be `PREFIX-ARCHITECTURE` for lines unique to a given architecture and `PREFIX` for lines common among X86/AArch64, so we don't duplicate lots of FileCheck lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157563/new/
https://reviews.llvm.org/D157563
More information about the llvm-commits
mailing list