[PATCH] D157563: [CodeGen] Move function splitting tests from X86 to Generic (NFC)

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/test/CodeGen/Generic/machine-function-splitter.ll:8
 ; RUN: sed 's/InstrProf/SampleProfile/g' %s > %t.ll
-; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-MFS
-; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-MFS2
+; COM: Machine function splitting with AFDO profiles on X86
+; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-X86-MFS
----------------
nit: Move this comment above the `RUN: sed` line since that's required for AFDO.


================
Comment at: llvm/test/CodeGen/Generic/machine-function-splitter.ll:9
+; COM: Machine function splitting with AFDO profiles on X86
+; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-X86-MFS
+; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-X86-MFS2
----------------
s/X86-MFS/MFS-X86/ to be consistent with the convention you've set in the prior RUN lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157563/new/

https://reviews.llvm.org/D157563