[PATCH] D155790: PreISelIntrinsicLowering: don't expand memcpys in minsize functions, even with no-builtins.

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 16:02:31 PDT 2023


hiraditya added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/no-expand-memcpy-minsize-no-builtins.ll:10
+; Check we don't expand memcpy to a loop when the caller is a minsize function,
+; even if we have no-builtins attached.
+define arm_aapcs_vfpcc void @test(ptr %p1, ptr %p2) #1 {
----------------
arsenm wrote:
> I don't understand this, minsize can't override an explicit don't-do-this
yeah, this could result in errors where there is no memcpy implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155790/new/

https://reviews.llvm.org/D155790



More information about the llvm-commits mailing list