[llvm] bdd17b8 - Remove a reference to rdar://problem/10664933

[Jon Roelofs via llvm-commits]

Author: Jon Roelofs
Date: 2023-08-09T15:10:08-07:00
New Revision: bdd17b853fac85c6542318a7fa0382f241869a57

URL: https://github.com/llvm/llvm-project/commit/bdd17b853fac85c6542318a7fa0382f241869a57
DIFF: https://github.com/llvm/llvm-project/commit/bdd17b853fac85c6542318a7fa0382f241869a57.diff

LOG: Remove a reference to rdar://problem/10664933

The original commit, and the comments in the code already provide sufficient
context. But for posterity, there's a tiny bit more that might be useful if
someone is digging here in the future:

> This is related to <rdar://problem/10318439> Lower invokes into terminating
> machine instructions.
>
> The return value from a function call is live in to that function call's
> landing pad. The landing pad is shared with a later call, and the variable is
> undef on the first exceptional edge.
>
> Our computation of the last legal split point gets confused because the
> return value is live-out from the calling block, and live-in to the landing
> pad, but it is not live on the edge itself.
>
> Fixed in r147911 and r147912.

Added: 
    

Modified: 
    llvm/lib/CodeGen/SplitKit.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SplitKit.cpp b/llvm/lib/CodeGen/SplitKit.cpp
index 83964eced5977e..1664c304f643c3 100644
--- a/llvm/lib/CodeGen/SplitKit.cpp
+++ b/llvm/lib/CodeGen/SplitKit.cpp
@@ -126,7 +126,6 @@ InsertPointAnalysis::computeLastInsertPoint(const LiveInterval &CurLI,
   // If the value leaving MBB was defined after the call in MBB, it can't
   // really be live-in to the landing pad.  This can happen if the landing pad
   // has a PHI, and this register is undef on the exceptional edge.
-  // <rdar://problem/10664933>
   if (!SlotIndex::isEarlierInstr(VNI->def, LIP.second) && VNI->def < MBBEnd)
     return LIP.first;